ci.yml: update vmactions/freebsd to v1 #421
Conversation
v1 is the most recommended to use and runs on ubuntu-latest instead of macos-12.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #421 +/- ##
==========================================
+ Coverage 65.75% 65.81% +0.06%
==========================================
Files 58 58
Lines 4520 4520
Branches 4177 4177
==========================================
+ Hits 2972 2975 +3
+ Misses 1548 1545 -3 ☔ View full report in Codecov by Sentry. |
|
Thanks! Yes, I have another branch where I'm trying to get this working: https://github.com/SimonKagstrom/kcov/tree/fix-freebsd-python2-tests, which also uses v1 now. However, for some reason, the bash tests no longer works with this one... |
I suspected that you also have patches ready. But why not Also, the error from FreeBSD is from "Copy files back from the VM", where there is an error due to a symlink skipping non-regular file "kcov/kcov/tests/python/link_main"When "Initialize files in VM" I see kcov/kcov/tests/python/link_main -> mainbut in this case there is error. |
I suspect the reason is that the default shell in FreeBSD may be tcsh. So |
|
It turned out to be a problem with file descriptor numbers. I fixed it with e27cb33 in the PR, which basically just disables it for FreeBSD. I don't think it's a very big issue. Probably broke with the newer FreeBSD I guess. As for ubuntu-latest, I'm sort of worried that the FreeBSD build will break again when 24.04 is released soonish. :-) |
|
Anyway, I'll close this PR since pretty much the same change is also part of #422, but thanks a lot for the discussion and insights! |
|
Thanks to you. |
v1 is the most recommended to use and runs on ubuntu-latest instead of macos-12.